> On Aug. 28, 2013, 8:18 p.m., Erin Noe-Payne wrote: > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/directives/RenderRegionWidget.js, > > line 24 > > <https://reviews.apache.org/r/13883/diff/2/?file=345808#file345808line24> > > > > angular is required but not injected
Does it need to be injected? The region widget seems to render for me and angular and angular.copy both exist without it being injected. I can send you along a patch with it rendering to the home portal page if you want. Let me know. - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13883/#review25684 ----------------------------------------------------------- On Aug. 28, 2013, 8:13 p.m., Daniel Gornstein wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13883/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 8:13 p.m.) > > > Review request for rave. > > > Repository: rave > > > Description > ------- > > This directive renders a region widget into the markup with the directive. > This just renders the iframe and does not take care of any chrome. That will > be dealt with in a different controller > > > Diffs > ----- > > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/directives/RenderRegionWidget.js > PRE-CREATION > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/directives/index.js > 1518158 > > /branches/angular/rave-portal-resources/src/main/webapp/static/script/common/resources/PagesForRenderResource.js > 1518158 > > Diff: https://reviews.apache.org/r/13883/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Gornstein > >
