> On Aug. 27, 2013, 5:12 p.m., Erin Noe-Payne wrote: > > In NavBarCtrl.js: > > > > $scope.user = $rootScope.user; > > > > This line is actually not necessary. Unless you use an isolate scope > > (applicable only to directives), scopes prototypically inherit from their > > containing scope - where rootScope is always the top of that hierarchy. So > > if 'user' is defined on rootScope it will already be defined on the scope > > of your NavBarCtrl with no need to inject and assign. You can set a break > > point to confirm that's true. > > > > I'd like to get this functionality into the branch so I'm fine with > > applying and correcting, but I want to point it out.
Thanks for pointing that out. I see that this has been corrected and applied, so I won't bother updating this patch. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13860/#review25624 ----------------------------------------------------------- On Aug. 27, 2013, 3:59 p.m., Michael Jett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13860/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2013, 3:59 p.m.) > > > Review request for rave. > > > Bugs: RAVE-1034 > https://issues.apache.org/jira/browse/RAVE-1034 > > > Repository: rave > > > Description > ------- > > (Angular) Setup nav bar menu controller > > > Diffs > ----- > > > Diff: https://reviews.apache.org/r/13860/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Navbar patch > > https://reviews.apache.org/media/uploaded/files/2013/08/27/Navbar_updated1.patch > > > Thanks, > > Michael Jett > >
