zongtanghu commented on a change in pull request #537: [ISSUE #525] Support the
message track
URL: https://github.com/apache/rocketmq/pull/537#discussion_r236489821
##########
File path:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
##########
@@ -261,10 +276,29 @@ public DefaultMQPushConsumer() {
* @param allocateMessageQueueStrategy message queue allocating algorithm.
*/
public DefaultMQPushConsumer(final String consumerGroup, RPCHook rpcHook,
- AllocateMessageQueueStrategy allocateMessageQueueStrategy) {
+ AllocateMessageQueueStrategy allocateMessageQueueStrategy, boolean
msgTraceSwitch) {
this.consumerGroup = consumerGroup;
this.allocateMessageQueueStrategy = allocateMessageQueueStrategy;
defaultMQPushConsumerImpl = new DefaultMQPushConsumerImpl(this,
rpcHook);
+ //if client open the message track trace feature
+ if (msgTraceSwitch) {
+ try {
+ Properties tempProperties = new Properties();
Review comment:
Hi @vongosling ,this parameters is default,I think it is comfortable to keep
this pattern.If we use a way of config,then users are more convenient to use
this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services