zongtanghu commented on a change in pull request #537: [ISSUE #525] Support the 
message track
URL: https://github.com/apache/rocketmq/pull/537#discussion_r236557447
 
 

 ##########
 File path: 
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
 ##########
 @@ -228,6 +228,14 @@ private synchronized RemotingCommand 
updateAndCreateTopic(ChannelHandlerContext
             return response;
         }
 
+        if (this.brokerController.getBrokerConfig().isAutoTraceBrokerEnable()) 
{
 
 Review comment:
   Thanks for your advice.But I think this code should be reserved.As you said, 
it can only prevent admin tools from create topic.In the side of 
autoCreateTopicEnable flag,I will solve this issue in the 
createTopicInSendMessageMethod.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to