fangjian0423 commented on a change in pull request #56: [ISSUE-46] Support
mutliple RocketMQTemplate & name-server overrided Consumer Listener
URL: https://github.com/apache/rocketmq-spring/pull/56#discussion_r274323563
##########
File path:
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/autoconfigure/ListenerContainerConfiguration.java
##########
@@ -107,15 +108,18 @@ private void registerContainer(String beanName, Object
bean) {
log.info("Register the listener to container, listenerBeanName:{},
containerBeanName:{}", beanName, containerBeanName);
}
- private DefaultRocketMQListenerContainer
createRocketMQListenerContainer(Object bean, RocketMQMessageListener
annotation) {
+ private DefaultRocketMQListenerContainer
createRocketMQListenerContainer(String name, Object bean,
RocketMQMessageListener annotation) {
DefaultRocketMQListenerContainer container = new
DefaultRocketMQListenerContainer();
- container.setNameServer(rocketMQProperties.getNameServer());
+ String nameServer =
environment.resolvePlaceholders(annotation.nameServer());
+ nameServer = StringUtils.isEmpty(nameServer) ?
rocketMQProperties.getNameServer() : nameServer;
+ container.setNameServer(nameServer);
container.setTopic(environment.resolvePlaceholders(annotation.topic()));
container.setConsumerGroup(environment.resolvePlaceholders(annotation.consumerGroup()));
container.setRocketMQMessageListener(annotation);
container.setRocketMQListener((RocketMQListener) bean);
container.setObjectMapper(objectMapper);
+ container.setName(name); // REVIEW ME, use the same clientId or
multiple?
Review comment:
I think multiple is better, multiple instance consumer & multiple instance
producer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
