fangjian0423 commented on a change in pull request #56: [ISSUE-46] Support 
mutliple RocketMQTemplate & name-server overrided Consumer Listener
URL: https://github.com/apache/rocketmq-spring/pull/56#discussion_r275629665
 
 

 ##########
 File path: 
rocketmq-spring-boot/src/main/java/org/apache/rocketmq/spring/autoconfigure/RocketMQAutoConfiguration.java
 ##########
 @@ -94,9 +95,10 @@ public RocketMQTemplate rocketMQTemplate(DefaultMQProducer 
mqProducer, ObjectMap
     }
 
     @Bean
-    @ConditionalOnBean(RocketMQTemplate.class)
+    @ConditionalOnBean(name = 
RocketMQConfigUtils.ROCKETMQ_TEMPLATE_DEFAULT_GLOBAL_NAME)
     @ConditionalOnMissingBean(TransactionHandlerRegistry.class)
-    public TransactionHandlerRegistry 
transactionHandlerRegistry(RocketMQTemplate template) {
+    public TransactionHandlerRegistry 
transactionHandlerRegistry(@Qualifier(RocketMQConfigUtils.ROCKETMQ_TEMPLATE_DEFAULT_GLOBAL_NAME)
 
 Review comment:
   Transactional Message used with default RocketMQTemplate.  It it should be 
used with multiple RocketMQTemplate?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to