vongosling commented on a change in pull request #1327: [ISSUE #1308] Fix a
spelling errors of a method name.
URL: https://github.com/apache/rocketmq/pull/1327#discussion_r303701697
##########
File path:
logging/src/main/java/org/apache/rocketmq/logging/InternalLogger.java
##########
@@ -21,43 +21,43 @@
String getName();
- void debug(String var1);
+ void debug(String msg);
- void debug(String var1, Object var2);
+ void debug(String format, Object arg);
- void debug(String var1, Object var2, Object var3);
+ void debug(String format, Object arg1, Object arg2);
- void debug(String var1, Object... var2);
+ void debug(String format, Object... arguments);
Review comment:
arguments->args would be better. and info, warn and error all have similar
problems.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
