vongosling commented on a change in pull request #1327: [ISSUE #1308] Fix a
spelling errors of a method name.
URL: https://github.com/apache/rocketmq/pull/1327#discussion_r303698223
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/consumer/PullAPIWrapper.java
##########
@@ -193,7 +193,7 @@ public PullResult pullKernelImpl(
String brokerAddr = findBrokerResult.getBrokerAddr();
if (PullSysFlag.hasClassFilterFlag(sysFlagInner)) {
- brokerAddr = computPullFromWhichFilterServer(mq.getTopic(),
brokerAddr);
+ brokerAddr = computePullFromWhichFilterServer(mq.getTopic(),
brokerAddr);
Review comment:
Could you do more further to polish the name of the
computePullFromWhichFilterServer?
it is not good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
