+1
> On Aug 29, 2019, at 19:40, ShannonDing <[email protected]> wrote:
>
> Hello RocketMQ Community,
>
> This is the vote for version 1.2.3 of Apache RocketMQ Client CPP.
>
>
>
>
> This release included main futures below:
>
> Support transaction message.
> Support C style batch message sending.
> Support getting error information when C API returns false.
> Polish the TCP transport layer.
> Remove useless code and fix compile warnings.
>
> For detail info, please see the release note.
>
>
>
>
> The artifacts:
>
> https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Frocketmq%2Frocketmq-client-cpp%2F1.2.3-rc2%2F&data=02%7C01%7C%7C563861e27f3d4f1333e708d72c75b66f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637026756385331635&sdata=Ak7gV98AWhpdQpvLYpOZ2XrF5uQsIJFB%2Ff5WvM%2FalBM%3D&reserved=0
>
>
>
>
> Git tag for the release:
>
> https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Frocketmq-client-cpp%2Ftree%2Frelease-1.2.3&data=02%7C01%7C%7C563861e27f3d4f1333e708d72c75b66f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637026756385341642&sdata=iSpK6xcaXIfA9o%2BAwza28pYmm4o0VWsnITHFQxmNQ2g%3D&reserved=0
>
>
>
>
> Hash for the release tag:
>
> dcf3a1f0b4c2b9826a391e40d053889ee4fafd91
>
>
>
>
> Release Notes:
>
> https://nam03.safelinks.protection.outlook.com/?url=http%3A%2F%2Frocketmq.apache.org%2Frelease_notes%2Frelease-notes-rocketmq-client-cpp-1.2.3%2F&data=02%7C01%7C%7C563861e27f3d4f1333e708d72c75b66f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637026756385341642&sdata=9joJVL3bBXcfx3LASc%2FSWMrOggCRMOZWhHgKv5PCw0M%3D&reserved=0
>
>
>
>
> The artifacts have been signed with Key :
>
> BBC3FBA877D30832E2FBC8F901B994150CD1E262, which can be found in the keys file:
>
> https://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdist.apache.org%2Frepos%2Fdist%2Fdev%2Frocketmq%2FKEYS&data=02%7C01%7C%7C563861e27f3d4f1333e708d72c75b66f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637026756385341642&sdata=ab40Ru8qLYM3opnv71fsaCYWa3uLia4XDxO0o2aqbJo%3D&reserved=0
>
>
>
>
> Checklist for reference,
>
> Note that this is not official policy but may help with checking releases.
>
> Fill in the following:
>
> [] Checksums and PGP signatures are valid for Source package.
>
> [] Checksums and PGP signatures are valid for Binary package.
>
> [] Source code artifacts have correct names matching the current release.
>
> [] Binary artifacts have correct names matching the current release.
>
> [] License and Notice are correct in source package.
>
> [] License and Notice are correct in binary package.
>
> [] All files have license headers in source package if necessary.
>
> [] No compiled archives bundled in source archive.
>
> [] Hash and Tag in GitHub repo is matching the current artifacts.
>
> [] The code can be built success in the source package.
>
> And any other check point is welcomed and please feel free to reply to this
> email, we sincerely hope to your feedback.
>
>
>
>
> The vote will be open for at least 72 hours or until necessary number of
>
> votes are reached.
>
> Please vote accordingly:
>
>
>
>
> [] +1 approve
>
> [] +0 no opinion
>
> [] -1 disapprove with the reason
>
>
>
>
> Thanks,
>
> The Apache RocketMQ Team
>
>