liuruiyiyang commented on a change in pull request #5: Add Broker Horizontal Up-scale and Broker Rolling Update when Name Service Scaling URL: https://github.com/apache/rocketmq-operator/pull/5#discussion_r325636273
########## File path: pkg/constants/constants.go ########## @@ -18,9 +18,10 @@ package constants const BrokerClusterPrefix = "broker-cluster-" -const MasterBrokerContainerNamePrefix = "broker-master" -const ReplicaBrokerContainerNamePrefix = "broker-replica" +const BrokerContainerName = "broker" const AdminToolDir = "/home/rocketmq/rocketmq-4.5.0/bin/mqadmin" Review comment: We will change the admin tool directory name to a version-free name later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
