liuruiyiyang commented on a change in pull request #5: Add Broker Horizontal
Up-scale and Broker Rolling Update when Name Service Scaling
URL: https://github.com/apache/rocketmq-operator/pull/5#discussion_r325636660
##########
File path: pkg/controller/nameservice/nameservice_controller.go
##########
@@ -188,9 +188,9 @@ func (r *ReconcileNameService)
updateNameServiceStatus(instance *rocketmqv1alpha
share.NameServersStr =
nameServerListStr[:len(nameServerListStr)-1]
reqLogger.Info("share.NameServersStr:" + share.NameServersStr)
- if len(oldNameServerListStr) < 2 {
+ if len(oldNameServerListStr) < 8 {
Review comment:
We will replace this magic number with a meaningful constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
