xujianhai666 commented on a change in pull request #1797: [ISSUE
#1796]feat(admin): remove extra code for getConsumeStats
URL: https://github.com/apache/rocketmq/pull/1797#discussion_r385522772
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -864,17 +864,6 @@ private RemotingCommand
getConsumeStats(ChannelHandlerContext ctx,
continue;
}
- {
- SubscriptionData findSubscriptionData =
-
this.brokerController.getConsumerManager().findSubscriptionData(requestHeader.getConsumerGroup(),
topic);
-
- if (null == findSubscriptionData
Review comment:
@duhenglucky I know ur idea, but this code should check the case: group is
not used, then the findSubscriptionData return null and
findSubscriptionDataCount return 0. As the code run, the not used group will
return back to user. so maybe we should distinguish two case, one as u say
above, and the second as I refer. Do u agree with that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
