duhenglucky commented on a change in pull request #1797: [ISSUE
#1796]feat(admin): remove extra code for getConsumeStats
URL: https://github.com/apache/rocketmq/pull/1797#discussion_r385532740
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/AdminBrokerProcessor.java
##########
@@ -864,17 +864,6 @@ private RemotingCommand
getConsumeStats(ChannelHandlerContext ctx,
continue;
}
- {
- SubscriptionData findSubscriptionData =
-
this.brokerController.getConsumerManager().findSubscriptionData(requestHeader.getConsumerGroup(),
topic);
-
- if (null == findSubscriptionData
Review comment:
yep, if the topic was set in the request, these codes look a bit messy, and
we need to deal with this in an elegant way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
