Hi,

+1 (binding)

I checked:
- signatures and hashes fine
- LICENSE and NOTICE looks OK
- All necessary files have license headers
- No compiled archives bundled in the source archive
- Release note seems clear for me

Best Regards,
Von Gosling


金融通 <[email protected]> 于2020年4月10日周五 下午3:48写道:

> +1,
> I checked
> -  Checksums and PGP signatures are valid for Source package.
> -  Checksums and PGP signatures are valid for Binary package.
> -  Hash and Tag in GitHub repo is matching the current artifacts.
> -  License and Notice are correct in source package.
> -  License and Notice are correct in binary package.
>
>
>
> &gt; -----原始邮件-----
> &gt; 发件人: ShannonDing <[email protected]>
> &gt; 发送时间: 2020-04-07 09:44:04 (星期二)
> &gt; 收件人: "[email protected]" <[email protected]>
> &gt; 抄送:
> &gt; 主题: [VOTE]Release Apache RocketMQ Client CPP 2.2.0 RC1.
> &gt;
> &gt; Hello RocketMQ Community,
> &gt; This is the vote for version 2.2.0 of Apache RocketMQ Client CPP.
> &gt; This release support TLS mode with OpenSSL for sending messages in
> sync model and consuming messages by push model and use an separate
> producer to send trace messages.
> &gt;
> &gt;
> &gt; The artifacts:
> &gt;
> https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/2.2.0-rc1/
> &gt
> <https://dist.apache.org/repos/dist/dev/rocketmq/rocketmq-client-cpp/2.2.0-rc1/&gt>;
> Git tag for the release:
> &gt; https://github.com/apache/rocketmq-client-cpp/releases/tag/2.2.0
> &gt <https://github.com/apache/rocketmq-client-cpp/releases/tag/2.2.0&gt>;
> Hash for the release tag:
> &gt; 6579eb637f81bca29f59f1e8645897a8c12a0871
> &gt; Release Notes:
> &gt;
> http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-2.2.0/
> &gt
> <http://rocketmq.apache.org/release_notes/release-notes-rocketmq-client-cpp-2.2.0/&gt>;
> The artifacts have been signed with Key :
> &gt; BC9E172DE1BA5B24EBB4A628177B55985D75751B, which can be found in the
> keys
> &gt; file:
> &gt; https://dist.apache.org/repos/dist/dev/rocketmq/KEYS
> &gt;
> &gt;
> &gt; Checklist for reference,
> &gt; Note that this is not official policy but may help with checking
> releases.
> &gt; Fill in the following:
> &gt; [ ]  Checksums and PGP signatures are valid for Source package.
> &gt; [ ]  Checksums and PGP signatures are valid for Binary package.
> &gt; [ ]  Source code artifacts have correct names matching the current
> release.
> &gt; [ ]  Binary artifacts have correct names matching the current release.
> &gt; [ ]  License and Notice are correct in source package.
> &gt; [ ]  License and Notice are correct in binary package.
> &gt; [ ]  All files have license headers in source package if necessary.
> &gt; [ ]  No compiled archives bundled in source archive.
> &gt; [ ]  Hash and Tag in GitHub repo is matching the current artifacts.
> &gt; [ ]  The code can be built success in the source package.
> &gt; And any other check point is welcomed and please feel free to reply
> to this email, we sincerely hope to your feedback.
> &gt;
> &gt;
> &gt; The vote will be open for at least 72 hours or until necessary number
> of
> &gt; votes are reached.
> &gt; Please vote accordingly:
> &gt;
> &gt;
> &gt; [ ] +1 approve
> &gt; [ ] +0 no opinion
> &gt; [ ] -1 disapprove with the reason
> &gt;
> &gt;
> &gt; Thanks,
> &gt; The Apache RocketMQ Team
> &gt;
> </[email protected]></[email protected]>



-- 
Nothing is impossible

Reply via email to