Yiyiyimu edited a comment on pull request #515:
URL: 
https://github.com/apache/rocketmq-client-go/pull/515#issuecomment-662982817


   Several places to be improved:
   - [ ] Currently could not implement 
[getBrokerClusterInfo](https://github.com/apache/rocketmq/blob/9f95a972e10e0681bc3f2d00e9957aa212e897b5/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java#L1326),
 due to missing address/timeout error. So `deleteTopic` could not add parameter 
`ClusterName` to find related broker address but `BrokerAddr` itself.
   - [ ] Currently could not implement 
[getTopicListFromNameServer](https://github.com/apache/rocketmq/blob/9f95a972e10e0681bc3f2d00e9957aa212e897b5/client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java#L1386),
 due to the same reason as above, so `topicList` could not be implemented.
   - [ ] createTopic: There is needs to initialize the client with broker 
address but not nameserver address, so could only import `topic` like sarama 
for Kafka, for simplified operation
   - [x] deleteTopic: `topic` as the single parameter, like sarama for Kafka, 
for simplified operation


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to