liuruiyiyang edited a comment on pull request #515: URL: https://github.com/apache/rocketmq-client-go/pull/515#issuecomment-682306426
@Yiyiyimu Hi, I have read your code and the CI log, there are several issues: 1. The CI environment does not have local rocketmq instance to connect. I suggest you take a look at how other test class do, like using mock. 2. In admin_test.go, sleep a second between create and delete top to avoid error that delete topic when the topic has not been created yet. 3. Create topic and delete topic test should be in order. Maybe you could test them in the same test function to ensure that. 4. If the clusterinfo function is not fully implemented yet, do not add its test function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
