RongtongJin commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r502851898
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -577,6 +577,7 @@ private RemotingCommand
handlePutMessageResult(PutMessageResult putMessageResult
messageExtBatch.setFlag(requestHeader.getFlag());
MessageAccessor.setProperties(messageExtBatch,
MessageDecoder.string2messageProperties(requestHeader.getProperties()));
messageExtBatch.setBody(request.getBody());
+ messageExtBatch.setPropertiesString(requestHeader.getProperties());
Review comment:
IMO, set properties has been done in this code
`MessageAccessor.setProperties(messageExtBatch,
MessageDecoder.string2messageProperties(requestHeader.getProperties()));`, so
we don't need add a new variable named propertiesString to MessageExtBatch to
do this thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
