AVP42 commented on a change in pull request #2343:
URL: https://github.com/apache/rocketmq/pull/2343#discussion_r503877637
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -577,6 +577,7 @@ private RemotingCommand
handlePutMessageResult(PutMessageResult putMessageResult
messageExtBatch.setFlag(requestHeader.getFlag());
MessageAccessor.setProperties(messageExtBatch,
MessageDecoder.string2messageProperties(requestHeader.getProperties()));
messageExtBatch.setBody(request.getBody());
+ messageExtBatch.setPropertiesString(requestHeader.getProperties());
Review comment:
Yes, I agree with you. My Intention was to avoid another transformation
since there was already a transformed string. I thought that
MessageExtBrokerInner is out of the same consideration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
