[GitHub] [rocketmq] iamqq23ue commented on pull request #2707: [ISSUE #2706] Fix the problem of returning SEND_OK after flush failed

Wed, 21 Apr 2021 19:25:40 -0700 


iamqq23ue commented on pull request #2707:
URL: https://github.com/apache/rocketmq/pull/2707#issuecomment-824491734


   Thanks。But in my test，there is no FLUSH_DISK_TIMEOUT，my client get 
SEND_OK.In fact，I first tested the impact of the file system read only and 
found this problem, and then I went to analyze the code.
   
   
   
   
   ------------------ 原始邮件 ------------------
   发件人:                                                                         
                                               "apache/rocketmq"                
                                                                    
***@***.***>;
   发送时间: 2021年4月22日(星期四) 上午10:17
   ***@***.***>;
   ***@***.******@***.***>;
   主题: Re: [apache/rocketmq] [ISSUE #2706]  Fix the problem of returning 
SEND_OK after flush failed  (#2707)
   
   
   
   
   
    
   @RongtongJin commented on this pull request.
    
   Good catch! But I feel that the change is a bit complicated. When the 
flushing error occurs, the location flushedPosition does not move and will 
return to the client FLUSH_DISK_TIMEOUT.
    
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to