iamqq23ue commented on pull request #2707:
URL: https://github.com/apache/rocketmq/pull/2707#issuecomment-824581923


   > Good catch! But I feel that the change is a bit complicated. When the 
flushing error occurs, the location flushedPosition does not move and will 
return to the client FLUSH_DISK_TIMEOUT.
   
   
    **this.flushedPosition.set(value);**
   You can see that this line of code will be executed no matter what。So even 
if an error is reported, the position will change。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to