wu-sheng commented on a change in pull request #2861:
URL: https://github.com/apache/rocketmq/pull/2861#discussion_r629015363
##########
File path: example/pom.xml
##########
@@ -52,5 +52,15 @@
<groupId>org.javassist</groupId>
<artifactId>javassist</artifactId>
</dependency>
+ <dependency>
+ <groupId>io.jaegertracing</groupId>
+ <artifactId>jaeger-core</artifactId>
+ <version>1.6.0</version>
Review comment:
Hi, thanks for reaching me here. SkyWalking supports RocketMQ through
our plugin system, so, we don't need to rely on the OpenTracing APIs layer,
also don't ask the RocketMQ community to change the source code.
Also, as a member of OpenTracing, I have to say, OpenTracing is no longer
active anymore. The members are either quit or join OpenTelemetry. OpenTracing
and OpenCensus have been merged. SkyWalking community already doesn't recommend
users to choose OpenTracing-SkyWalking bridge.
RocketMQ 3.x and 4.x plugins are available here
1.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/rocketMQ-4.x-plugin
2.
https://github.com/apache/skywalking/tree/master/apm-sniffer/apm-sdk-plugin/rocketMQ-3.x-plugin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
