vongosling commented on a change in pull request #2861:
URL: https://github.com/apache/rocketmq/pull/2861#discussion_r629285023



##########
File path: example/pom.xml
##########
@@ -52,5 +52,15 @@
             <groupId>org.javassist</groupId>
             <artifactId>javassist</artifactId>
         </dependency>
+        <dependency>
+            <groupId>io.jaegertracing</groupId>
+            <artifactId>jaeger-core</artifactId>
+            <version>1.6.0</version>

Review comment:
       Nice reminder~ nowadays, its dependency is provided scope. I would like 
to keep a close eye on this field.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to