AshleyLiuuuuu opened a new pull request #3106:
URL: https://github.com/apache/rocketmq/pull/3106
**Make sure set the target branch to `develop`**
[ISSUES #3105]
## What is the purpose of the change
1. When the set time is equal to string now, the offset of rollback should
be consistent with the current maximum consumption offset.
2. So if the time set by user is now, the timestamp should be directly set
to -1 to call the method getMaxOffsetInQueue() in the Broker2Clitent.class as
shown below,and if the getOffsetInQueueByTime() is called when the timestamp is
"now", because of the algorithmthe of binary search in method, the returned
offset will not equal to the maximum offset and will only returns the offset of
the second-to-last message that is not up to expectations.
## Brief changelog
1. Added comment content of the reason why the timestamp is set to -1 when
it's equal to string "now".
2. When the set time is equal to "now", in order to call method
getMaxOffsetInQueue(), it will assigned a value of -1.
## Verifying this change
When the timestamp is set to now, the offset returned by the console will be
less than the actual maximum offset.
As shown below:
Follow this checklist to help us incorporate your contribution quickly and
easily. Notice, `it would be helpful if you could finish the following 5
checklist(the last one is not necessary)before request the community to review
your PR`.
- [x] Make sure there is a [Github
issue](https://github.com/apache/rocketmq/issues) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
Github issue. Your pull request should address just this issue, without pulling
in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException
when host config not exist`. Each commit in the pull request should have a
meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic
correction, more mock a little better when cross module dependency exist. If
the new feature or significant change is committed, please remember to add
integration-test in [test
module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs
checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install
-DskipITs` to make sure unit-test pass. Run `mvn clean test-compile
failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual
Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
