odbozhou commented on a change in pull request #3106:
URL: https://github.com/apache/rocketmq/pull/3106#discussion_r661377356
##########
File path:
tools/src/main/java/org/apache/rocketmq/tools/command/offset/ResetOffsetByTimeCommand.java
##########
@@ -75,7 +75,8 @@ public void execute(CommandLine commandLine, Options options,
RPCHook rpcHook) t
String group = commandLine.getOptionValue("g").trim();
String topic = commandLine.getOptionValue("t").trim();
String timeStampStr = commandLine.getOptionValue("s").trim();
- long timestamp = timeStampStr.equals("now") ?
System.currentTimeMillis() : 0;
+ //when the param "timestamp" is set to now,it should return the
max offset of this queue
+ long timestamp = timeStampStr.equals("now") ? -1 : 0;
Review comment:
How to change to -1 is still in line with the semantics of now？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
