guyinyou commented on a change in pull request #3208:
URL: https://github.com/apache/rocketmq/pull/3208#discussion_r680813564
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -713,15 +713,25 @@ private TopicPublishInfo tryToFindTopicPublishInfo(final
String topic) {
TopicPublishInfo topicPublishInfo =
this.topicPublishInfoTable.get(topic);
if (null == topicPublishInfo || !topicPublishInfo.ok()) {
this.topicPublishInfoTable.putIfAbsent(topic, new
TopicPublishInfo());
- this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic);
topicPublishInfo = this.topicPublishInfoTable.get(topic);
+ if (!topicPublishInfo.checkNotFoundFlag()) {
+ this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic);
+ topicPublishInfo = this.topicPublishInfoTable.get(topic);
+ }
}
if (topicPublishInfo.isHaveTopicRouterInfo() || topicPublishInfo.ok())
{
return topicPublishInfo;
} else {
- this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic,
true, this.defaultMQProducer);
- topicPublishInfo = this.topicPublishInfoTable.get(topic);
+ boolean found;
+ if (!topicPublishInfo.checkNotFoundFlag()) {
+ found =
this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic, true,
this.defaultMQProducer);
Review comment:
(MQClientInstance.updateTopicRouteInfoFromNameServer, line624)
```
if (topicRouteData != null) {
TopicRouteData old = this.topicRouteTable.get(topic);
boolean changed = topicRouteDataIsChange(old, topicRouteData);
...
if (changed) {
...
return true
}
...
}
return false;
```
1、TBW102 not found. Return false because the topicRouteData of TBW102 is
null.
2、TBW102 found. Return true because it is different from topicRouteData of
the origin topic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
