guyinyou commented on a change in pull request #3208:
URL: https://github.com/apache/rocketmq/pull/3208#discussion_r681394818
##########
File path:
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java
##########
@@ -713,15 +713,25 @@ private TopicPublishInfo tryToFindTopicPublishInfo(final
String topic) {
TopicPublishInfo topicPublishInfo =
this.topicPublishInfoTable.get(topic);
if (null == topicPublishInfo || !topicPublishInfo.ok()) {
this.topicPublishInfoTable.putIfAbsent(topic, new
TopicPublishInfo());
- this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic);
topicPublishInfo = this.topicPublishInfoTable.get(topic);
+ if (!topicPublishInfo.checkNotFoundFlag()) {
+ this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic);
+ topicPublishInfo = this.topicPublishInfoTable.get(topic);
+ }
}
if (topicPublishInfo.isHaveTopicRouterInfo() || topicPublishInfo.ok())
{
return topicPublishInfo;
} else {
- this.mQClientFactory.updateTopicRouteInfoFromNameServer(topic,
true, this.defaultMQProducer);
- topicPublishInfo = this.topicPublishInfoTable.get(topic);
+ boolean found;
Review comment:
I may not understand.
However, a correct process is to first get the origin topic when the
notFoundFlag is false, and then check topicPublishInfo whether it is work,
otherwise check the notFoundFlag again and decide whether to get TBW102.
And only when both origin topic and TBW102 are not work, set their
notFoundFlag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
