odbozhou commented on a change in pull request #701:
URL: https://github.com/apache/rocketmq-externals/pull/701#discussion_r696341702
##########
File path:
rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/OffsetManagementServiceImpl.java
##########
@@ -154,7 +178,6 @@ public void onCompletion(Throwable error, String key,
Map<ByteBuffer, ByteBuffer
boolean changed = false;
switch (OffsetChangeEnum.valueOf(key)) {
case ONLINE_KEY:
- mergeOffsetInfo(result);
Review comment:
I agree with your opinion.
I think there will still be problems.
needSyncPartition will only increase and not delete, because there is no
place to call remove.
For example, if task1 runs on worker1 at first, some tasks are added later,
and task1 is distributed to worker2 to run through load balancing, worker1 may
still synchronize the data to other nodes, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
