odbozhou commented on a change in pull request #701:
URL: https://github.com/apache/rocketmq-externals/pull/701#discussion_r696553519
##########
File path:
rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/OffsetManagementServiceImpl.java
##########
@@ -154,7 +178,6 @@ public void onCompletion(Throwable error, String key,
Map<ByteBuffer, ByteBuffer
boolean changed = false;
switch (OffsetChangeEnum.valueOf(key)) {
case ONLINE_KEY:
- mergeOffsetInfo(result);
Review comment:
There is no problem with this point. The problem I said is load
balancing in the cluster. For example, in the scenario of adding a task, task1
synchronizes data on the worker1 node. When the data location is partition
1:50, a new task is added. Task1 is assigned to the worker2 node, and the
synchronization data location in worker2 reaches partition 1:100. Because
worker1 and worker2 send record location information to add partition1 to
needSyncPartition, so worker1 and worker2 will synchronize partition1 to other
nodes, and partition1 of worker1 has expired , Worker2 is the latest, and at
this time, it may cause the problem that the site is overwritten by the old data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
