Git-Yang commented on a change in pull request #701:
URL: https://github.com/apache/rocketmq-externals/pull/701#discussion_r696538440
##########
File path:
rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/OffsetManagementServiceImpl.java
##########
@@ -154,7 +178,6 @@ public void onCompletion(Throwable error, String key,
Map<ByteBuffer, ByteBuffer
boolean changed = false;
switch (OffsetChangeEnum.valueOf(key)) {
case ONLINE_KEY:
- mergeOffsetInfo(result);
Review comment:
In the sendNeedSynchronizeOffset() method, the needSyncPartition will be
initialized after the offset is sent to prevent old data from being sent
repeatedly. So I think the offset that is synchronized every time is the latest
data.
I don't know if this can answer your question, if not, I hope you can
describe it in detail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
