Git-Yang commented on a change in pull request #701:
URL: https://github.com/apache/rocketmq-externals/pull/701#discussion_r696658563
##########
File path:
rocketmq-connect/rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/service/OffsetManagementServiceImpl.java
##########
@@ -154,7 +178,6 @@ public void onCompletion(Throwable error, String key,
Map<ByteBuffer, ByteBuffer
boolean changed = false;
switch (OffsetChangeEnum.valueOf(key)) {
case ONLINE_KEY:
- mergeOffsetInfo(result);
Review comment:
I got it, thanks.
For position, the problem can be solved in ISSUE #699 by waiting for a
period of time when a new task is started to check whether the position has
been synchronized to the latest.
For offset, I think it can be solved in the same way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
