caigy commented on a change in pull request #3357:
URL: https://github.com/apache/rocketmq/pull/3357#discussion_r709701419
##########
File path:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
##########
@@ -635,8 +636,16 @@ public SocketAddress getStoreHost() {
}
private String diskUtil() {
- String storePathPhysic =
this.brokerController.getMessageStoreConfig().getStorePathCommitLog();
- double physicRatio =
UtilAll.getDiskPartitionSpaceUsedPercent(storePathPhysic);
+ double physicRatio = -1;
+ String storePath
=this.brokerController.getMessageStoreConfig().getStorePathCommitLog();
+ if (storePath.contains(MessageStoreConfig.MULTI_PATH_SPLITTER)) {
+ String[] paths =
storePath.trim().split(MessageStoreConfig.MULTI_PATH_SPLITTER);
+ for (String storePathPhysic : paths) {
+ physicRatio = Math.min(physicRatio,
UtilAll.getDiskPartitionSpaceUsedPercent(storePathPhysic));
Review comment:
Is `Math.min()` correct here? `physicRatio` is initialized as `-1` and
`UtilAll.getDiskPartitionSpaceUsedPercent()` always returns value greater or
equal to `-1`.
##########
File path:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -782,10 +783,20 @@ private String getStorePathPhysic() {
public HashMap<String, String> getRuntimeInfo() {
HashMap<String, String> result =
this.storeStatsService.getRuntimeInfo();
- {
- double physicRatio =
UtilAll.getDiskPartitionSpaceUsedPercent(getStorePathPhysic());
+ String commitLogStorePath =
DefaultMessageStore.this.getMessageStoreConfig().getStorePathCommitLog();
+ if
(commitLogStorePath.contains(MessageStoreConfig.MULTI_PATH_SPLITTER)) {
+ double maxValue = Double.MIN_VALUE;
Review comment:
Is `maxPhysicsUsedRatio` more appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
