Jason918 commented on a change in pull request #3357:
URL: https://github.com/apache/rocketmq/pull/3357#discussion_r709717805
##########
File path:
store/src/main/java/org/apache/rocketmq/store/DefaultMessageStore.java
##########
@@ -782,10 +783,20 @@ private String getStorePathPhysic() {
public HashMap<String, String> getRuntimeInfo() {
HashMap<String, String> result =
this.storeStatsService.getRuntimeInfo();
- {
- double physicRatio =
UtilAll.getDiskPartitionSpaceUsedPercent(getStorePathPhysic());
+ String commitLogStorePath =
DefaultMessageStore.this.getMessageStoreConfig().getStorePathCommitLog();
+ if
(commitLogStorePath.contains(MessageStoreConfig.MULTI_PATH_SPLITTER)) {
+ double maxValue = Double.MIN_VALUE;
Review comment:
@caigy Yes, `maxPhysicsUsedRatio` is better .
But after some consideration, I think we should use `minPhysicsUsedRatio`.
It's more useful for admins, because we use min value of all store path to
determine whether disk is full and we should clean disk immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
