duhenglucky commented on a change in pull request #3490:
URL: https://github.com/apache/rocketmq/pull/3490#discussion_r749941782
##########
File path:
client/src/test/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyServiceTest.java
##########
@@ -62,9 +65,7 @@
import static org.mockito.ArgumentMatchers.anyLong;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.nullable;
-import static org.mockito.Mockito.doReturn;
-import static org.mockito.Mockito.spy;
-import static org.mockito.Mockito.when;
+import static org.mockito.Mockito.*;
Review comment:
Aggregating all imports is not a good practice.
##########
File path:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
##########
@@ -163,6 +163,11 @@
*/
private int consumeThreadMax = 20;
+ /**
+ * Queue size of consumption request;
+ */
+ private int consumeQueueSize = 10000;
Review comment:
If we set up a bounded queue, one issue that needs to be considered is
how to choose the rejection strategy when the queue is full, because this may
cause message loss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
