XiaoyiPeng commented on a change in pull request #3490:
URL: https://github.com/apache/rocketmq/pull/3490#discussion_r749952325
##########
File path:
client/src/main/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumer.java
##########
@@ -163,6 +163,11 @@
*/
private int consumeThreadMax = 20;
+ /**
+ * Queue size of consumption request;
+ */
+ private int consumeQueueSize = 10000;
Review comment:
Thanks for reminding.
The original rejection strategy is good. If the caller catch an
RejectedExecutionException, it try to submit again after a delay. and the delay
increases exponentially until it reaches a maximum.
This PR has implementation and unit tests that don't cause messages to be
lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
