vongosling commented on a change in pull request #57:
URL: https://github.com/apache/rocketmq-dashboard/pull/57#discussion_r777804960
##########
File path:
src/main/java/org/apache/rocketmq/dashboard/service/impl/ConsumerServiceImpl.java
##########
@@ -295,6 +301,9 @@ public boolean deleteSubGroup(DeleteSubGroupRequest
deleteSubGroupRequest) {
for (String brokerName :
deleteSubGroupRequest.getBrokerNameList()) {
logger.info("addr={} groupName={}",
clusterInfo.getBrokerAddrTable().get(brokerName).selectBrokerAddr(),
deleteSubGroupRequest.getGroupName());
mqAdminExt.deleteSubscriptionGroup(clusterInfo.getBrokerAddrTable().get(brokerName).selectBrokerAddr(),
deleteSubGroupRequest.getGroupName(), true);
+ // delete %RETRY%+Group and %DLQ%+Group in broker and namesrv
+ deleteDlqOrRetryTopic(MixAll.RETRY_GROUP_TOPIC_PREFIX +
deleteSubGroupRequest.getGroupName(), brokerName, clusterInfo);
+ deleteDlqOrRetryTopic(MixAll.DLQ_GROUP_TOPIC_PREFIX +
deleteSubGroupRequest.getGroupName(), brokerName, clusterInfo);
Review comment:
deleteResources will be better than the existing method name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
