zhangjidi2016 commented on a change in pull request #57:
URL: https://github.com/apache/rocketmq-dashboard/pull/57#discussion_r777874278
##########
File path:
src/test/java/org/apache/rocketmq/dashboard/controller/ConsumerControllerTest.java
##########
@@ -182,6 +182,8 @@ public void testDelete() throws Exception {
final String url = "/consumer/deleteSubGroup.do";
{
doNothing().when(mqAdminExt).deleteSubscriptionGroup(any(),
anyString());
+ doNothing().when(mqAdminExt).deleteTopicInBroker(any(),
anyString());
Review comment:
No need here，mock these two delete interfaces indicate that the topic
has been deleted successfully on the broker side, the unit test only need to
care about the code logic in the dashboard before and after the deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
