Slideee commented on code in PR #117:
URL: https://github.com/apache/rocketmq-connect/pull/117#discussion_r857080938
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/RmqSourceReplicator.java:
##########
@@ -117,10 +119,10 @@ public void start() {
}
buildRoute();
- startListner();
+ startListener();
Review Comment:
> startListener may not be needed, because the runtime has already done the
load balancing logic, and put the load balancing queue in the context of each
task
I don't think it should be deleted, because the startListener method
maintains changes in topic information, and the runtime maintains changes in
task configuration and load balancing. Changes to a topic should not be
maintained by the runtime :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
