odbozhou commented on code in PR #117:
URL: https://github.com/apache/rocketmq-connect/pull/117#discussion_r861482464
##########
connectors/rocketmq-replicator/src/main/java/org/apache/rocketmq/replicator/RmqSourceReplicator.java:
##########
@@ -188,7 +195,7 @@ public Class<? extends Task> taskClass() {
}
@Override
- public List<KeyValue> taskConfigs() {
+ public List<KeyValue> taskConfigs(int maxTasks) {
if (!configValid) {
Review Comment:
>
1、Yes，maxTask should replace taskParallelism.
2、min (number of shards, maxTasks) should also be implemented. This is also
easier to understand. If there are only 2 shards and maxTasks=5, the number of
tasks can only be 2, which is why the number of tasks is maxTasks instead of
taskNum. For example, the data source has only 2 topics, or 2 tables,
maxTasks=5, the dimension of the shard is topic or table, and the final task
data is 2, min(topicNum, maxTasks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
