zhouxinyu commented on code in PR #4980:
URL: https://github.com/apache/rocketmq/pull/4980#discussion_r962452820
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java:
##########
@@ -225,7 +224,11 @@ public PullResult getMessage(String group, String topic,
int queueId, long offse
getMessageResult.getMaxOffset(), foundList);
} else {
- POP_LOGGER.error("get message from store return null. topic={},
groupId={}, requestOffset={}", topic, group, offset);
+ long maxQueueOffset =
brokerController.getMessageStore().getMaxOffsetInQueue(topic, queueId);
Review Comment:
Log always if a null result is returned. I think this is an exceptional
case. For the typical case, a clear result should be returned, even if `offset
> maxOffset`(OFFSET_OVERFLOW_BADLY is returned).
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java:
##########
@@ -198,12 +198,11 @@ public PullResult getMessage(String group, String topic,
int queueId, long offse
break;
case NO_MATCHED_MESSAGE:
pullStatus = PullStatus.NO_MATCHED_MSG;
- POP_LOGGER.warn("no matched message. GetMessageStatus={},
topic={}, groupId={}, requestOffset={}",
+ POP_LOGGER.info("no matched message. GetMessageStatus={},
topic={}, groupId={}, requestOffset={}",
Review Comment:
`NO_MATCHED_MESSAGE` means the pulled messages are filtered, so I think
`info` is enough, maybe debug is a better level.
##########
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java:
##########
@@ -206,7 +206,7 @@ public Thread newThread(Runnable r) {
.channel(useEpoll() ? EpollServerSocketChannel.class :
NioServerSocketChannel.class)
.option(ChannelOption.SO_BACKLOG, 1024)
.option(ChannelOption.SO_REUSEADDR, true)
- .option(ChannelOption.SO_KEEPALIVE, false)
+ .childOption(ChannelOption.SO_KEEPALIVE, false)
Review Comment:
The default value of childOption is true or false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
