lizhanhui commented on code in PR #4980:
URL: https://github.com/apache/rocketmq/pull/4980#discussion_r962482290
##########
broker/src/main/java/org/apache/rocketmq/broker/processor/PopReviveService.java:
##########
@@ -225,7 +224,11 @@ public PullResult getMessage(String group, String topic,
int queueId, long offse
getMessageResult.getMaxOffset(), foundList);
} else {
- POP_LOGGER.error("get message from store return null. topic={},
groupId={}, requestOffset={}", topic, group, offset);
+ long maxQueueOffset =
brokerController.getMessageStore().getMaxOffsetInQueue(topic, queueId);
Review Comment:
At present, a clean start-up would observe bulks of errors in the server.
This is unwanted and intimidating to new users. IMO, it's good to log
conditionally and add potential ones if there is a need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
