Oliverwqcwrw commented on code in PR #5153:
URL: https://github.com/apache/rocketmq/pull/5153#discussion_r977154922
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1326,12 +1326,10 @@ public TransactionSendResult
sendMessageInTransaction(final Message msg,
}
if (localTransactionState !=
LocalTransactionState.COMMIT_MESSAGE) {
- log.info("executeLocalTransactionBranch return {}",
localTransactionState);
- log.info(msg.toString());
+ log.info("executeLocalTransactionBranch return: {}
message: {}", localTransactionState, msg);
}
} catch (Throwable e) {
- log.info("executeLocalTransactionBranch exception", e);
- log.info(msg.toString());
+ log.error("executeLocalTransactionBranch exception,
message: {}", msg, e);
Review Comment:
Thanks for your review
Logger supports this format,
maybe we can just print a few key messages instead of the entire message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
