caigy commented on code in PR #5153:
URL: https://github.com/apache/rocketmq/pull/5153#discussion_r978245050
##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -1326,10 +1326,12 @@ public TransactionSendResult
sendMessageInTransaction(final Message msg,
}
if (localTransactionState !=
LocalTransactionState.COMMIT_MESSAGE) {
- log.info("executeLocalTransactionBranch return: {}
message: {}", localTransactionState, msg);
+ log.info("executeLocalTransactionBranch return: {}
messageTopic: {} transactionId: {}",
+ localTransactionState, msg.getTopic(),
msg.getTransactionId());
Review Comment:
IMO message tag and key should be logged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
