nowinkeyy commented on code in PR #5193:
URL: https://github.com/apache/rocketmq/pull/5193#discussion_r980675241
##########
broker/src/test/java/org/apache/rocketmq/broker/topic/TopicQueueMappingManagerTest.java:
##########
@@ -44,12 +44,12 @@
public class TopicQueueMappingManagerTest {
@Mock
private BrokerController brokerController;
- private static final String broker1Name = "broker1";
+ private static final String BROKER1_NAME = "broker1";
Review Comment:
IMO, if defined as brokerName, it should not be a constant. Both are ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
