[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #5193: [ISSUE #5122] Enable checkstyle for test code (rocketmq-broker module)

Tue, 27 Sep 2022 19:32:38 -0700 


tsunghanjacktsai commented on code in PR #5193:
URL: https://github.com/apache/rocketmq/pull/5193#discussion_r981882491


##########
README.md:
##########
@@ -1,12 +1,13 @@
-## Apache RocketMQ 
-[![Build 
Status](https://travis-ci.org/apache/rocketmq.svg?branch=master)](https://travis-ci.org/apache/rocketmq)
 [![Coverage 
Status](https://coveralls.io/repos/github/apache/rocketmq/badge.svg?branch=master)](https://coveralls.io/github/apache/rocketmq?branch=master)
-[![CodeCov](https://codecov.io/gh/apache/rocketmq/branch/master/graph/badge.svg)](https://codecov.io/gh/apache/rocketmq)
-[![Maven 
Central](https://maven-badges.herokuapp.com/maven-central/org.apache.rocketmq/rocketmq-all/badge.svg)](http://search.maven.org/#search%7Cga%7C1%7Corg.apache.rocketmq)
-[![GitHub 
release](https://img.shields.io/badge/release-download-orange.svg)](https://rocketmq.apache.org/dowloading/releases)
-[![License](https://img.shields.io/badge/license-Apache%202-4EB1BA.svg)](https://www.apache.org/licenses/LICENSE-2.0.html)
-[![Average time to resolve an 
issue](http://isitmaintained.com/badge/resolution/apache/rocketmq.svg)](http://isitmaintained.com/project/apache/rocketmq
 "Average time to resolve an issue")
-[![Percentage of issues still 
open](http://isitmaintained.com/badge/open/apache/rocketmq.svg)](http://isitmaintained.com/project/apache/rocketmq
 "Percentage of issues still open")
-[![Twitter 
Follow](https://img.shields.io/twitter/follow/ApacheRocketMQ?style=social)](https://twitter.com/intent/follow?screen_name=ApacheRocketMQ)
+## Apache RocketMQ
+

Review Comment:
   Is the change relevant to the main purpose of this PR?



##########
.asf.yaml:
##########
@@ -27,7 +27,7 @@ github:
     # Enable squash button
     squash: true
     # Disable merge button
-    merge: true
+    merge: false

Review Comment:
   What is the purpose of modifying this parameter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to