Hi, @Willem
We want to do source-only release in dist-dir[1] and publish the binary *.jar to maven central repo, is this ok? [1]. https://dist.apache.org/repos/dist/..... @Justin > Tags in git are changeable so it best to include a tag and a hash in the official vote email. Great idea, we will include a tag and the hash in the vote email: The tag is here: https://github.com/apache/incubator-rocketmq/tree/rocketmq-all-4.0.0-incubating The tag hash is: 5cd35c871d06c21b5fd9f148858ed5a9a27b9d5e Regards, yukon On Fri, Feb 3, 2017 at 8:57 AM, yukon <[email protected]> wrote: > Hi Justin, > > Many thanks for your scrupulous check, the mentioned > file(hs_err_pid87490.log) shouldn't be in the release, the branding issues > of rocketmq-site and the concerns in README will be resolved before a vote. > > As for https://github.com/rocketmq, we are considering moving these > projects into RocketMQ when there are some release versions. > > Regards, > yukon > > > On Fri, Feb 3, 2017 at 6:13 AM, Justin Mclean <[email protected]> > wrote: > >> Hi, >> >> I checked: >> - incubating in name >> - contains DISCLAIMER >> - LICENSE and NOTICE good. NOTICE year needs to be updated to 2017. >> - No unexpected binary files in source release >> - All source file have ASF headers >> - Can compile form source >> >> And that would be enough the get a +1 from me on the incubator general >> list. >> >> Should this file be in the release? [1] >> >> The incubating site has a few minor branding issues. The IPMC often look >> at your site when voting on a release so might be a good idea to update it. >> >> Some minor concerns I have over the README: >> - it seems to has a number of links to a commercial 3rd party product >> product? (https://cn.aliyun.com/product/ons) >> - it points users at stack overflow and quora to ask question, users >> should be directed to the mailing lists first >> - under a header “RocketMQ Community” it includes links to docker and >> this GitHub https://github.com/rocketmq >> - branding wise it better to use “Apache RocketMQ” rather than just >> RocketMQ >> >> Why is there code being developed at https://github.com/rocketmq outside >> of the RocketMQ project? >> >> Thanks, >> Justin >> >> 1. rocketmq-all-4.0.0-incubating/store/hs_err_pid87490.log > > >
