Hi,

> Many thanks for your scrupulous check, the mentioned
> file(hs_err_pid87490.log) shouldn't be in the release, the branding issues
> of rocketmq-site and the concerns in README will be resolved before a vote.

As this is your first release, not everything needs to be fixed or be perfect 
before a vote is called. In fact as long it’s fixed before graduating that’s 
fine.

Looks to me that the release is in a good shape, there’s some minor branding 
issues and year wrong in NOTICE and an extra error log file.

There are not serious issues and could even be fixed next release, but also 
they are easy to fix now :-)

> As for https://github.com/rocketmq, we are considering moving these
> projects into RocketMQ when there are some release versions.

Great! I would consider moving them sooner (before making a release) rather 
than later. There is likely to be less process involved if you move sooner ie 
you may need to fill out a software grant to move a large amount of code into 
the RocketMQ repo.You may also need to get all GitHub users to sign ICLAs if 
they haven’t done so. IMO it's far better to have active development on those 
projects here rather than in github.

Thanks,
Justin

Reply via email to