GitHub user StyleTang opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/72
https://issues.apache.org/jira/browse/ROCKETMQ-134
when different string has a same hash code.the message commit offset of
filtered message may be not commit to broker.
for example:
1.consumer pull message from broker, broker return status FOUND and
messages filter by tags hash code
2.consumer client get the messages and than processPullResult will filter
message by tags.
3.PullCallback may get a pullResult which status is FOUND but messageList
is empty.(filter by tags)
but only NO_MATCHED_MSG and NO_NEW_MSG will correctTagsOffset
we can't commit the right with status of FOUND(for messageList is empty).
Is that so?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StyleTang/incubator-rocketmq message-tags
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit a4e22b6d8008ab0402b9e1909ef4c8061b8e9908
Author: tangjie <[email protected]>
Date: 2017-03-08T07:59:01Z
https://issues.apache.org/jira/browse/ROCKETMQ-134
fix status isFOUND,but no matched messages. commit offset will not commit
to broker problem.
(string's hash code is the same but string value not)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
