Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/72
You are right , but this is actually not a very big problem since though
the offset this round is not committed, the pull request for next round is
still continue so next time the offset will still committed.
If the consumer crashes at that moment, an unnecessary pull request will be
submitted, which is the what the problem actually is , but it is very minor.
Please firstly relate the JIRA in your descriptions.
For this PR, I don't suggest doing correctTags when pull list is empty
because it is always empty as long as there is no message.
If this issue should be solved, I suggest modify the pull result to
NO_MATCHED when pulling some message but filter by client by tag in method
`processPullResult`
//filter by client again and no messages left
if(msgListFilterAgain.isEmpty() && !msgList.isEmpty()) {
pullResultExt.setPullStatus(PullStatus.NO_MATCHED_MSG);
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
