Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/80#discussion_r114733685
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -95,52 +141,65 @@ public static BrokerController
createBrokerController(String[] args) {
final BrokerConfig brokerConfig = new BrokerConfig();
final NettyServerConfig nettyServerConfig = new
NettyServerConfig();
final NettyClientConfig nettyClientConfig = new
NettyClientConfig();
- nettyServerConfig.setListenPort(10911);
+ nettyServerConfig.setListenPort(10911); // Set default broker
listen port
final MessageStoreConfig messageStoreConfig = new
MessageStoreConfig();
if (BrokerRole.SLAVE == messageStoreConfig.getBrokerRole()) {
+
+ // Use a conservative value for slave brokers so that
consumer groups won't frequently change targeting
+ // brokers when they are consuming messages at the
boundary between being probably resident in physical
+ // memory and swapped out.
int ratio =
messageStoreConfig.getAccessMessageInMemoryMaxRatio() - 10;
messageStoreConfig.setAccessMessageInMemoryMaxRatio(ratio);
}
- if (commandLine.hasOption('p')) {
+ // FIXME: log should not be null
--- End diff --
Creating a JIRA issue for this and having its number as a comment is a good
practice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
