Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/80#discussion_r114733797
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/processor/SendMessageProcessor.java
---
@@ -112,18 +156,21 @@ private RemotingCommand consumerSendMsgBack(final
ChannelHandlerContext ctx, fin
return response;
}
+ // Make sure message store of the broker is writable.
if
(!PermName.isWriteable(this.brokerController.getBrokerConfig().getBrokerPermission()))
{
response.setCode(ResponseCode.NO_PERMISSION);
response.setRemark("the broker[" +
this.brokerController.getBrokerConfig().getBrokerIP1() + "] sending message is
forbidden");
return response;
}
+ // TODO: we should warn client here because OP may carelessly get
things wrong here.
--- End diff --
I think this needs another JIRA issue too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
